-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supercluster by cuttlefish schema (aka multibag name chage) #1257
Conversation
For testing |
%% value is a PB address of Riak node to connect. | ||
{mapping, "supercluster.member.$member_id", "riak_cs_multibag.bags", [ | ||
{datatype, ip}, | ||
{include_default, "bag-A"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The best way is to match the string here with one in the doc (in the future.) This is not user-facing because of hidden
, how about leaving as it is and defer change ?
With unreachable IP address lines like
The setup 1.4 code seems broken there; case application:get_env(stop_when_done) of
{ok, true} ->
io:fwrite("Setup stopping...~n", []),
timer:sleep(timer:seconds(5)),
rpc:eval_everywhere(init,stop,[0]);
_ ->
timer:sleep(infinity)
end. This is fixed in latest exometer_core 1.4 that is using setup 1.5. |
But this is not a issue of this pull request. Going to 👍 |
Supercluster by cuttlefish schema (aka multibag name chage) Reviewed-by: kuenishi
@borshop merge |
For release note: supercluster (aka multibag) configuration can be done in riak-cs.conf and stanchion.conf. For members of supercluster, riak-cs.conf and stanchion.conf:
and refresh interval for riak-cs.conf
Also, |
Addition from [1] and [2]. Settings for
(for stanchion, change For backward compatibility, advanced.config or app.config for
or
Somewhat complicated because of back tax. [1] #1260 |
A little change for
s/multibag/supercluster/
by cuttlefish schema.This PR depends on following PRs: